OTLP exporter add User-Agent header#4120
Merged
alanwest merged 9 commits intoopen-telemetry:mainfrom Feb 1, 2023
Merged
Conversation
vishweshbankwar
approved these changes
Jan 31, 2023
cijothomas
reviewed
Jan 31, 2023
src/OpenTelemetry.Exporter.OpenTelemetryProtocol/OtlpExporterOptions.cs
Outdated
Show resolved
Hide resolved
cijothomas
reviewed
Jan 31, 2023
cijothomas
approved these changes
Jan 31, 2023
Member
cijothomas
left a comment
cijothomas
left a comment
There was a problem hiding this comment.
left couple of small comments.
Kielek
approved these changes
Jan 31, 2023
…lemetry-dotnet into alanwest/otlp-user-agent
cijothomas
approved these changes
Jan 31, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4120 +/- ##
==========================================
- Coverage 85.57% 85.56% -0.02%
==========================================
Files 293 293
Lines 11359 11371 +12
==========================================
+ Hits 9721 9730 +9
- Misses 1638 1641 +3
|
Comment on lines
+211
to
+212
| var assemblyName = typeof(OtlpExporterOptions).Assembly.GetName(); | ||
| return assemblyName.Version; |
Member
There was a problem hiding this comment.
IMHO it would be better to use either the assembly file version (blue) or even better the assembly informational version (green) instead of the assembly version (red) as it's much more granular:
I'd be happy to submit a PR to do that if people agree.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3724