[sdk-logs] Update LogRecord for Logger API additions#4456
Merged
alanwest merged 1 commit intoopen-telemetry:mainfrom May 2, 2023
Merged
[sdk-logs] Update LogRecord for Logger API additions#4456alanwest merged 1 commit intoopen-telemetry:mainfrom
alanwest merged 1 commit intoopen-telemetry:mainfrom
Conversation
53 tasks
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4456 +/- ##
==========================================
- Coverage 83.41% 83.35% -0.06%
==========================================
Files 313 313
Lines 12485 12512 +27
==========================================
+ Hits 10414 10430 +16
- Misses 2071 2082 +11
|
alanwest
reviewed
Apr 28, 2023
| /// <summary> | ||
| /// Gets or sets the log <see cref="LogRecordSeverity"/>. | ||
| /// </summary> | ||
| internal LogRecordSeverity? Severity |
Member
Author
There was a problem hiding this comment.
I feel like Nullable is more the .NET way for saying a value type is unspecified but originally I didn't have LogRecordSeverity.Unspecified defined 🤣 If you think it would be better to just default to that and drop Nullable I'm good with it.
Member
There was a problem hiding this comment.
I'm ok leaving this for now. Good question though.. I think we should opt for one or the other: nullable or Unspecified. I think I'll open an issue where we can capture a punch list of small questions like this for us to circle back to before we declare stable.
alanwest
reviewed
Apr 28, 2023
alanwest
approved these changes
May 2, 2023
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #4433
Changes
LogRecordfor additions ofLogger,SeverityText, andSeverity.Merge requirement checklist