Merged
Conversation
alanwest
reviewed
Jun 1, 2023
Comment on lines
+21
to
24
| #pragma warning disable SA1623 // The property's documentation summary text should begin with: `Gets or sets` | ||
| /// <summary> | ||
| /// Represents an Exemplar data. | ||
| /// </summary> |
Member
There was a problem hiding this comment.
Weird.. the style cops didn't catch this before? 👮♂️
Contributor
Author
There was a problem hiding this comment.
It complains about it only when I mark the struct internal.
There was a problem hiding this comment.
Why disable the warning instead of just updating the text?
alanwest
reviewed
Jun 1, 2023
alanwest
approved these changes
Jun 1, 2023
Member
alanwest
left a comment
alanwest
left a comment
There was a problem hiding this comment.
looks like you just have an annoying "unnecessary using" problem, but other than that LETM (looks exemplary to me)
reyang
approved these changes
Jun 1, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4533 +/- ##
==========================================
+ Coverage 85.30% 85.60% +0.29%
==========================================
Files 320 320
Lines 12647 12611 -36
==========================================
+ Hits 10789 10796 +7
+ Misses 1858 1815 -43
|
Member
|
@utpilla Please add entry in changelog, so users won't be surprised. You can hint that Exemplars will be added back for the 1.6* pre-releases immediately after 1.5 stable is out. |
This was referenced Jun 1, 2023
mfogliatto
pushed a commit
to mfogliatto/opentelemetry-dotnet
that referenced
this pull request
Jun 10, 2023
Co-authored-by: Alan West <3676547+alanwest@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes