[sdk-1.5.0-hotfix] Removed support for parsing custom log states using reflection#4614
Merged
CodeBlanch merged 5 commits intoopen-telemetry:main-1.5.0from Jun 26, 2023
Conversation
utpilla
reviewed
Jun 26, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main-1.5.0 #4614 +/- ##
==============================================
- Coverage 85.60% 85.59% -0.01%
==============================================
Files 320 320
Lines 12620 12617 -3
==============================================
- Hits 10803 10800 -3
Misses 1817 1817
|
alanwest
reviewed
Jun 26, 2023
|
|
||
| var warnings = expectedOutput.ToString().Split('\n', '\r').Where(line => line.Contains("warning IL")); | ||
| Assert.Equal(43, warnings.Count()); | ||
| Assert.Equal(42, warnings.Count()); |
alanwest
approved these changes
Jun 26, 2023
utpilla
reviewed
Jun 26, 2023
utpilla
approved these changes
Jun 26, 2023
Contributor
utpilla
left a comment
utpilla
left a comment
There was a problem hiding this comment.
Left some minor suggestions.
utpilla
approved these changes
Jun 26, 2023
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Greetings 👋 If you have landed on this PR from the CHANGELOG entry and were using the parsing feature or have a need for such a feature please drop a comment. We have options/ideas for how we could put this feature back in a way that would be compatible with AOT but prioritization of that effort will be based largely on feedback.]
Note: This PR is targeting main-1.5.0 branch.
Relates to #4609
See #4609 (comment)
Changes
ILogger.Log<TState>which do not implement the expected interfaces.Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes