Update Prometheus exporter name and unit processing#4753
Merged
CodeBlanch merged 12 commits intoopen-telemetry:mainfrom Aug 16, 2023
Merged
Update Prometheus exporter name and unit processing#4753CodeBlanch merged 12 commits intoopen-telemetry:mainfrom
CodeBlanch merged 12 commits intoopen-telemetry:mainfrom
Conversation
Contributor
Author
reyang
reviewed
Aug 8, 2023
...Telemetry.Exporter.Prometheus.AspNetCore/OpenTelemetry.Exporter.Prometheus.AspNetCore.csproj
Outdated
Show resolved
Hide resolved
reyang
reviewed
Aug 8, 2023
src/OpenTelemetry.Exporter.Prometheus.HttpListener/Internal/PrometheusMetric.cs
Show resolved
Hide resolved
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #4753 +/- ##
==========================================
+ Coverage 82.12% 82.40% +0.27%
==========================================
Files 313 314 +1
Lines 12783 12910 +127
==========================================
+ Hits 10498 10638 +140
+ Misses 2285 2272 -13
|
CodeBlanch
reviewed
Aug 9, 2023
utpilla
reviewed
Aug 10, 2023
src/OpenTelemetry.Exporter.Prometheus.HttpListener/Internal/PrometheusMetric.cs
Show resolved
Hide resolved
utpilla
reviewed
Aug 10, 2023
src/OpenTelemetry.Exporter.Prometheus.HttpListener/Internal/PrometheusSerializerExt.cs
Outdated
Show resolved
Hide resolved
utpilla
reviewed
Aug 10, 2023
src/OpenTelemetry.Exporter.Prometheus.HttpListener/Internal/PrometheusMetric.cs
Outdated
Show resolved
Hide resolved
utpilla
reviewed
Aug 10, 2023
test/OpenTelemetry.Exporter.Prometheus.HttpListener.Tests/PrometheusMetricTests.cs
Show resolved
Hide resolved
…ometheusMetric.cs Co-authored-by: Utkarsh Umesan Pillai <66651184+utpilla@users.noreply.github.com>
utpilla
reviewed
Aug 10, 2023
src/OpenTelemetry.Exporter.Prometheus.HttpListener/Internal/PrometheusCollectionManager.cs
Show resolved
Hide resolved
utpilla
reviewed
Aug 10, 2023
src/OpenTelemetry.Exporter.Prometheus.HttpListener/Internal/PrometheusSerializerExt.cs
Show resolved
Hide resolved
utpilla
reviewed
Aug 10, 2023
src/OpenTelemetry.Exporter.Prometheus.HttpListener/Internal/PrometheusMetric.cs
Show resolved
Hide resolved
utpilla
approved these changes
Aug 11, 2023
Contributor
Author
|
There are some failing tests. Are they broken by this PR or flaky tests? |
Contributor
Not related to your PR. That's a flaky test. Tracking issue #4763 |
CodeBlanch
approved these changes
Aug 11, 2023
Member
CodeBlanch
left a comment
There was a problem hiding this comment.
LGTM with a CHANGELOG update
Contributor
Author
|
I'd like to get this in for the next OTel release. Also, I'd like to be able to use these changes right now from the nightly feed. What work remains before this can be merged? |
Member
|
@JamesNK I'm happy to merge but I do think this is a substantial change we should mention in the logs:
Something like this should work... ## Unreleased
* Added support for unit and name conversion following the [OpenTelemetry Specification](https://github.com/open-telemetry/opentelemetry-specification/blob/065b25024549120800da7cda6ccd9717658ff0df/specification/compatibility/prometheus_and_openmetrics.md?plain=1#L235-L240)
([#4753](https://github.com/open-telemetry/opentelemetry-dotnet/pull/4753)) |
Contributor
Author
|
Done. |
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4742
Design discussion issue #
Changes
Updates the .NET Prometheus exporter to follow the metric and unit naming rules.
See https://github.com/open-telemetry/opentelemetry-specification/blob/b2f923fb1650dde1f061507908b834035506a796/specification/compatibility/prometheus_and_openmetrics.md#otlp-metric-points-to-prometheus
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes