Skip to content

[OpenTracing.Shim] Remove obsolete constructor#4862

Merged
utpilla merged 1 commit intoopen-telemetry:mainfrom
Kielek:opentracing-shim-cleanup
Sep 18, 2023
Merged

[OpenTracing.Shim] Remove obsolete constructor#4862
utpilla merged 1 commit intoopen-telemetry:mainfrom
Kielek:opentracing-shim-cleanup

Conversation

@Kielek
Copy link
Copy Markdown
Member

@Kielek Kielek commented Sep 18, 2023

Cleanup for #4812

Changes

Remove obsolete constructor from OpenTracing Shim.

Merge requirement checklist

  • CONTRIBUTING guidelines followed (nullable enabled, static analysis, etc.)
  • [ ] Unit tests added/updated handled in previous PR.
  • Appropriate CHANGELOG.md files updated for non-trivial changes
  • Changes in public API reviewed (if applicable)

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 18, 2023

Codecov Report

Merging #4862 (135d8a9) into main (fe78453) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4862      +/-   ##
==========================================
+ Coverage   83.91%   83.93%   +0.02%     
==========================================
  Files         293      293              
  Lines       12028    12021       -7     
==========================================
- Hits        10093    10090       -3     
+ Misses       1935     1931       -4     
Files Changed Coverage
src/OpenTelemetry.Shims.OpenTracing/TracerShim.cs ø

@Kielek
Copy link
Copy Markdown
Member Author

Kielek commented Sep 18, 2023

Failed test OpenTelemetry.Exporter.Prometheus.Tests.PrometheusHttpListenerTests.PrometheusExporterHttpServerIntegration_NoMetrics on net462 not related to changes.

@Kielek Kielek marked this pull request as ready for review September 18, 2023 05:07
@Kielek Kielek requested a review from a team September 18, 2023 05:07
@Kielek
Copy link
Copy Markdown
Member Author

Kielek commented Sep 18, 2023

@pjanotti, FYI

Copy link
Copy Markdown
Contributor

@pjanotti pjanotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants