Fix TraceContextPropagator behavior when trace parent flags contain…#4893
Conversation
258e8e0 to
cf29bfb
Compare
…s illegal characters. fixes: test_traceparent_trace_flags_illegal_characters
cf29bfb to
7fe4d2d
Compare
Codecov Report
@@ Coverage Diff @@
## main #4893 +/- ##
==========================================
+ Coverage 83.26% 83.30% +0.04%
==========================================
Files 295 295
Lines 12324 12325 +1
==========================================
+ Hits 10261 10267 +6
+ Misses 2063 2058 -5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
@open-telemetry/dotnet-approvers, I have 2 more tests fixes ready to review on separate branch. As it touches some internal implementation/decision it is worth to make separate reviews. If you think otherwise I can bring all of them in one PR. Finally it passes all W3c tests on .NET7+. 2 other fixes on the top of branch: https://github.com/Kielek/opentelemetry-dotnet/commits/tace-context-propagator-other-fixes |
Fixes test_traceparent_trace_flags_illegal_characters from w3c test suite
Design discussion issue #
Changes
Fix
TraceContextPropagatorbehavior when trace parent flags contains illegal characters.Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes[ ] Changes in public API reviewed (if applicable)