[Instrumentation.AspNetCore] .NET6 library works on .NET7 and .NET8#5252
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5252 +/- ##
==========================================
- Coverage 83.38% 83.01% -0.38%
==========================================
Files 297 272 -25
Lines 12531 11975 -556
==========================================
- Hits 10449 9941 -508
+ Misses 2082 2034 -48
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
@vishweshbankwar, I have heard that you have discussed it with @rajkumar-rangaraj. If you are fine with the changes. It will be great to release 1.7.1 version (also for HTTP package). |
Co-authored-by: Reiley Yang <reyang@microsoft.com>
...emetry.Instrumentation.AspNetCore/AspNetCoreInstrumentationMeterProviderBuilderExtensions.cs
Outdated
Show resolved
Hide resolved
@Kielek I discussed this with @rajkumar-rangaraj again in detail. I think this can be handled on auto-instrumentation side without including the proposed changes in this PR. @rajkumar-rangaraj will follow up with you offline. |
94287c4 to
cbba3d6
Compare
src/OpenTelemetry.Instrumentation.AspNetCore/Implementation/HttpInListener.cs
Show resolved
Hide resolved
src/OpenTelemetry.Instrumentation.AspNetCore/Implementation/HttpInListener.cs
Outdated
Show resolved
Hide resolved
…onTracerProviderBuilderExtensions with HttpInListener
|
@open-telemetry/dotnet-maintainers, could you please review and merge? We have had pretty long discussion with @rajkumar-rangaraj and @vishweshbankwar, and it is locally the best option to solve the issue on Auto Instrumentation side. |
Fixes #N/A
Design discussion issue #N/A
Changes
Fixes scenario when .NET6 targeted library is loaded into .NET7/.NET8 process (it is case which we have in AutoInstrumentation side) or even .NET7 to .NET8 for metrics.
If we speaking about additional conditional checks - only .NET6 and .NET7 suffers.
Minimal duplication of code is there. I think all of this stuff will be dropped in November this year.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes