Skip to content

Add MinVerTagPrefix for SQL and gRPC instrumentation#5337

Merged
alanwest merged 3 commits intoopen-telemetry:mainfrom
alanwest:alanwest/minvertags
Feb 9, 2024
Merged

Add MinVerTagPrefix for SQL and gRPC instrumentation#5337
alanwest merged 3 commits intoopen-telemetry:mainfrom
alanwest:alanwest/minvertags

Conversation

@alanwest
Copy link
Copy Markdown
Member

@alanwest alanwest commented Feb 9, 2024

In prep for release #5322.

SQL and gRPC instrumentation has not yet received a release that aligns major/minor version with the 1.7 API/SDK release.

@alanwest alanwest requested a review from a team February 9, 2024 19:01
Copy link
Copy Markdown
Member

@CodeBlanch CodeBlanch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CodeBlanch CodeBlanch added area:instrumentation infra Infra work - CI/CD, code coverage, linters labels Feb 9, 2024
@utpilla
Copy link
Copy Markdown
Contributor

utpilla commented Feb 9, 2024

@alanwest We could probably use a dedicated tag for Shims.OpenTracing as well (just for consistency)?

Would you want to update the RELEASING docwith these changes?

…Instrumentation.GrpcNetClient.csproj

Co-authored-by: Utkarsh Umesan Pillai <66651184+utpilla@users.noreply.github.com>
@alanwest
Copy link
Copy Markdown
Member Author

alanwest commented Feb 9, 2024

Would you want to update the RELEASING docwith these changes?

Yep, sounds good. I'm going to first focus on getting the release out, but I will follow up with updating our release instructions.

@alanwest alanwest merged commit 8325786 into open-telemetry:main Feb 9, 2024
@alanwest alanwest deleted the alanwest/minvertags branch February 9, 2024 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infra Infra work - CI/CD, code coverage, linters

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants