Remove OpenTelemetry.SemanticConventions project#5539
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5539 +/- ##
==========================================
+ Coverage 83.38% 85.54% +2.16%
==========================================
Files 297 289 -8
Lines 12531 12605 +74
==========================================
+ Hits 10449 10783 +334
+ Misses 2082 1822 -260
Flags with carried forward coverage won't be shown. Click here to find out more. |
alanwest
left a comment
There was a problem hiding this comment.
👍 I suggested we drop this project in the SIG meeting. Almost pushed up my branch and opened this PR... guess you beat me to it 😆
|
I just unlisted the package from NuGet... should stop showing in search results shortly. |
|
What is the urgency here? What we talked about on the SIG was we would land #5531 and then do this as a follow-up. Now I have to go sort out conflicts. Are we practicing good professional courtesy? What sort of collaborative environment do we want to foster? |
Are these questions for me? |
Maintenance - this package should not come from the opentelemetry-dotnet repository, opentelemetry-dotnet is only intended for core components such as the API / SDK / plugins required by the specification / infrastructure components. If there is high demand, opentelemetry-dotnet-contrib is the right place #5539 (comment). |
Follow up #5531 (comment).
If users find the project useful, might be a good fit for the opentelemetry-dotnet-contrib repo.