[sdk-metrics] Add support for .NET 9 Advice API#5854
[sdk-metrics] Add support for .NET 9 Advice API#5854CodeBlanch merged 11 commits intoopen-telemetry:mainfrom
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5854 +/- ##
==========================================
+ Coverage 83.38% 86.29% +2.91%
==========================================
Files 297 257 -40
Lines 12531 11194 -1337
==========================================
- Hits 10449 9660 -789
+ Misses 2082 1534 -548
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
@rajkumar-rangaraj Do you know if httpclient, aspnetcore started leveraging the advice for providing custom buckets ? |
I haven't checked this part yet. |
|
Definitely need a CHANGELOG for this one 😄 |
np! We just need to make sure we don't remove the hardcoded buckets that exist today in sdk, until that happens and old versions are out of support. |
I also suggest to document this near https://github.com/open-telemetry/opentelemetry-dotnet/tree/main/docs/metrics/customizing-the-sdk#explicit-bucket-histogram-aggregation and recommend users to leverage Advice, wherever feasible |
Created an issue to track doc changes separately - #5855 |
…b.com/rajkumar-rangaraj/opentelemetry-dotnet into rajrang/add-instrument-advice-support
Fixes #5487
Design discussion issue #
Changes
Please provide a brief description of the changes here.
Merge requirement checklist
CHANGELOG.mdfiles updated for non-trivial changes