Fix and disable HttpWebRequest test#797
Merged
cijothomas merged 1 commit intoopen-telemetry:masterfrom Jul 10, 2020
cijothomas:cijothomas/httpwebrequesttestdisable
Merged
Fix and disable HttpWebRequest test#797cijothomas merged 1 commit intoopen-telemetry:masterfrom cijothomas:cijothomas/httpwebrequesttestdisable
cijothomas merged 1 commit intoopen-telemetry:masterfrom
cijothomas:cijothomas/httpwebrequesttestdisable
Conversation
eddynaka
approved these changes
Jul 10, 2020
Codecov Report
@@ Coverage Diff @@
## master #797 +/- ##
==========================================
+ Coverage 71.68% 73.21% +1.52%
==========================================
Files 220 220
Lines 6929 6929
Branches 1157 1157
==========================================
+ Hits 4967 5073 +106
+ Misses 1653 1542 -111
- Partials 309 314 +5
|
reyang
approved these changes
Jul 10, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
This HttpWebRequest unit test was passing accidentally. This PR fixes the test logic, and it is now expected to fail until we have the ability to filter httpwebrequest calls, which we don't have yet.
An actual fix would likely come with this PR: (or with alternate solution to support filtering)
#741
At this stage, the only way to filter out httpwebrequests is by writing custom ActivityProcessors.