Suppress instrumentation upon calling ActivityExporter.ExportAsync#967
Closed
alanwest wants to merge 1 commit intoopen-telemetry:reyang/suppress-instrumentationfrom
Conversation
alanwest
commented
Aug 1, 2020
| { | ||
| var originalString = requestUri.OriginalString; | ||
|
|
||
| // zipkin |
Member
Author
There was a problem hiding this comment.
I did a quick manual test with Zipkin, so I removed this filter.
alanwest
commented
Aug 1, 2020
Comment on lines
+337
to
+341
| var previous = Sdk.SuppressInstrumentation; | ||
| Sdk.SuppressInstrumentation = true; | ||
| var result = await this.exporter.ExportAsync(this.batch, cancellationToken).ConfigureAwait(false); | ||
| Sdk.SuppressInstrumentation = previous; | ||
|
|
Member
Author
There was a problem hiding this comment.
This is where SuppressInstrumentation is actually set.
alanwest
commented
Aug 1, 2020
Comment on lines
+33
to
+36
| if (Sdk.SuppressInstrumentation) | ||
| { | ||
| return; | ||
| } |
Member
Author
There was a problem hiding this comment.
Checking SuppressInstrumentation in one spot to avoid reentering pipeline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft PR, currently targeting @reyang's currently unmerged PR #960
Sorry, it's a bit of a noisy diff because I made some changes to the abstract
ActivityProcessorclass trying out the idea of checking theSuppressInstrumentationbit in one spot. I think this will work (??). Though, perf may be the concern here.This only touches tracing at this point, though will want the same kind of thing for metric export as well.