Ensure IsValid functions also check length#2244
Closed
errordeveloper wants to merge 1 commit intoopen-telemetry:mainfrom
Closed
Ensure IsValid functions also check length#2244errordeveloper wants to merge 1 commit intoopen-telemetry:mainfrom
IsValid functions also check length#2244errordeveloper wants to merge 1 commit intoopen-telemetry:mainfrom
Conversation
errordeveloper
force-pushed
the
check-len
branch
from
e59131d to
bc5c229
Compare
Author
|
This was a bit misinformed, closing... |
MrAlias
added a commit
that referenced
this pull request
May 23, 2025
Resolve #6811 Resolve #6691 No migration documentation is added. This does not contain any breaking changes between v1.34.0 and v1.33.0 for the Go API. ## [`v1.34.0` semantic convention release notes](https://github.com/open-telemetry/semantic-conventions/releases/tag/v1.34.0): <h3>🛑 Breaking changes 🛑</h3> <ul> <li> <p><code>all</code>: Convert deprecated text to structured format. (<a href="open-telemetry/semantic-conventions#2047" data-hovercard-type="pull_request" data-hovercard-url="/open-telemetry/semantic-conventions/pull/2047/hovercard">#2047</a>)<br> This is a breaking change from the schema perspective, but does not change anything for instrumentations or the end users. It breaks compatibility with the (old) <a href="open-telemetry/build-tools#322" data-hovercard-type="issue" data-hovercard-url="/open-telemetry/build-tools/issues/322/hovercard">code generation tooling</a>. Please use <a href="https://github.com/open-telemetry/weaver">weaver</a> to generate Semantic Conventions markdown or code.</p> </li> <li> <p><code>feature_flag</code>: Move the evaluated value from the event body to attributes (<a href="open-telemetry/semantic-conventions#1990" data-hovercard-type="pull_request" data-hovercard-url="/open-telemetry/semantic-conventions/pull/1990/hovercard">#1990</a>)</p> </li> <li> <p><code>process</code>: Require sensitive data sanitization for <code>process.command_args</code> and <code>process.command_line</code> (<a href="open-telemetry/semantic-conventions#626" data-hovercard-type="issue" data-hovercard-url="/open-telemetry/semantic-conventions/issues/626/hovercard">#626</a>)</p> </li> </ul> <h3>💡 Enhancements 💡</h3> <ul> <li><code>docs</code>: Document system-specific naming conventions (<a href="open-telemetry/semantic-conventions#608" data-hovercard-type="issue" data-hovercard-url="/open-telemetry/semantic-conventions/issues/608/hovercard">#608</a>, <a href="open-telemetry/semantic-conventions#1494" data-hovercard-type="issue" data-hovercard-url="/open-telemetry/semantic-conventions/issues/1494/hovercard">#1494</a>, <a href="open-telemetry/semantic-conventions#1708" data-hovercard-type="pull_request" data-hovercard-url="/open-telemetry/semantic-conventions/pull/1708/hovercard">#1708</a>)</li> <li><code>gen-ai</code>: Add <code>gen_ai.conversation.id</code> attribute (<a href="open-telemetry/semantic-conventions#2024" data-hovercard-type="issue" data-hovercard-url="/open-telemetry/semantic-conventions/issues/2024/hovercard">#2024</a>)</li> <li><code>all</code>: Renames all <code>resource.*</code> groups to be <code>entity.*</code> (<a href="open-telemetry/semantic-conventions#2244" data-hovercard-type="pull_request" data-hovercard-url="/open-telemetry/semantic-conventions/pull/2244/hovercard">#2244</a>)<br> Part of <a class="issue-link js-issue-link" data-error-text="Failed to load title" data-id="2885075816" data-permission-text="Title is private" data-url="open-telemetry/opentelemetry-specification#4436" data-hovercard-type="issue" data-hovercard-url="/open-telemetry/opentelemetry-specification/issues/4436/hovercard" href="https://github.com/open-telemetry/opentelemetry-specification/issues/4436">open-telemetry/opentelemetry-specification#4436</a></li> <li><code>aws</code>: Added new AWS attributes for various services including SQS, SNS, Bedrock, Step Functions, Secrets Manager and Kineses (<a href="open-telemetry/semantic-conventions#1794" data-hovercard-type="pull_request" data-hovercard-url="/open-telemetry/semantic-conventions/pull/1794/hovercard">#1794</a>)</li> <li><code>cloud</code>: Broaden <code>cloud.region</code> definition to explicitly cover both resource location and targeted destination. (<a href="open-telemetry/semantic-conventions#2142" data-hovercard-type="issue" data-hovercard-url="/open-telemetry/semantic-conventions/issues/2142/hovercard">#2142</a>)</li> <li><code>network</code>: Stabilize <code>network.transport</code> enum value <code>quic</code>. (<a href="open-telemetry/semantic-conventions#2275" data-hovercard-type="pull_request" data-hovercard-url="/open-telemetry/semantic-conventions/pull/2275/hovercard">#2275</a>)</li> </ul> <h3>🧰 Bug fixes 🧰</h3> <ul> <li><code>db</code>: Fix the <code>db.system.name</code> attribute value for MySQL which was incorrectly pointing to <code>microsoft.sql_server</code>. (<a href="open-telemetry/semantic-conventions#2276" data-hovercard-type="pull_request" data-hovercard-url="/open-telemetry/semantic-conventions/pull/2276/hovercard">#2276</a>)</li> </ul>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.