Fix incorrect aggregation; Prometheus exporter behavior#903
Merged
jmacd merged 15 commits intoopen-telemetry:masterfrom Jul 7, 2020
Merged
Fix incorrect aggregation; Prometheus exporter behavior#903jmacd merged 15 commits intoopen-telemetry:masterfrom
jmacd merged 15 commits intoopen-telemetry:masterfrom
Conversation
added 7 commits
July 3, 2020 10:14
jmacd
requested review from
Aneurysm9,
MrAlias,
evantorrie,
lizthegrey and
paivagustavo
as code owners
lizthegrey
reviewed
Jul 6, 2020
added 3 commits
July 6, 2020 08:33
lizthegrey
approved these changes
Jul 6, 2020
Member
lizthegrey
left a comment
lizthegrey
left a comment
There was a problem hiding this comment.
please make sure you note the bug fix in the CHANGELOG.
Contributor
Author
|
Done
|
cbandy
reviewed
Jul 6, 2020
MrAlias
approved these changes
Jul 7, 2020
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a bug in
FinishCollection()that would double-apply stale updates for instruments that had not been modified in the most recent collection interval. This corrects the incorrect aggregation.This adds further correctness and testing for Prometheus. The basic processor supports a new
Memoryoption that says whether to remember and report metric instruments and label sets that were not modified in the most recent collection interval. TheTestProcessortest is refactored to reduce indentation level. New tests are added for the delta and cumulative case, where a stateful aggregator may be called for and the no-memory configuration still suppresses reporting for unmodified data.Resolves #887.