Support thread.name attributes in RuleBasedRoutingSampler#1030
Merged
trask merged 10 commits intoopen-telemetry:mainfrom Sep 18, 2023
Merged
Support thread.name attributes in RuleBasedRoutingSampler#1030trask merged 10 commits intoopen-telemetry:mainfrom
thread.name attributes in RuleBasedRoutingSampler#1030trask merged 10 commits intoopen-telemetry:mainfrom
Conversation
trask
reviewed
Sep 7, 2023
samplers/src/main/java/io/opentelemetry/contrib/sampler/RuleBasedRoutingSampler.java
Outdated
Show resolved
Hide resolved
trask
changed the title
thread.id and thread.name attributes in RuleBasedRoutingSampler
Member
|
looks good! can you add a test for this in |
trask
reviewed
Sep 17, 2023
samplers/src/main/java/io/opentelemetry/contrib/sampler/RuleBasedRoutingSampler.java
Outdated
Show resolved
Hide resolved
trask
approved these changes
Sep 18, 2023
samplers/src/test/java/io/opentelemetry/contrib/sampler/RuleBasedRoutingSamplerTest.java
Outdated
Show resolved
Hide resolved
…sedRoutingSamplerTest.java Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
heyams
changed the title
thread.id and thread.name attributes in RuleBasedRoutingSamplerthread.name attributes in RuleBasedRoutingSampler
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
per this comment open-telemetry/semantic-conventions#213 (review)