Add kafka client metrics to the javaagent instrumentation#6533
Add kafka client metrics to the javaagent instrumentation#6533trask merged 3 commits intoopen-telemetry:mainfrom
Conversation
|
Closing and re-opening to trigger latest dep tests |
trask
left a comment
trask
left a comment
There was a problem hiding this comment.
@mateuszrzeszutek are these metrics on-by-default?
|
Yes, enabled by default. |
|
oh, sorry, I meant to bring this up in SIG meeting today, I was unsure whether this should be on by default or not, since these are not spec'd metrics, but I guess we're considering it to be similar to micrometer (which is enabled by default)? one other related concern is that I didn't see an easy way to disable them (without defining a metrics view)? |
I think it probably makes sense to have them enabled by default, since it's a bridge/shim-like instrumentation, like micrometer. Making it easy to turn this off sounds good though, I'll add a property for disabling them 👍 |
…etry#6533) * Add kafka client metrics to the javaagent instrumentation * Don't override user-set metrics reporter * Add kafka metric reporter config property
…etry#6533) * Add kafka client metrics to the javaagent instrumentation * Don't override user-set metrics reporter * Add kafka metric reporter config property
…etry#6533) * Add kafka client metrics to the javaagent instrumentation * Don't override user-set metrics reporter * Add kafka metric reporter config property
4 participants
Resolves #5941