Move micrometer shim library instrumentation back#6538
Merged
trask merged 3 commits intoopen-telemetry:mainfrom Sep 7, 2022
Merged
Move micrometer shim library instrumentation back#6538trask merged 3 commits intoopen-telemetry:mainfrom
trask merged 3 commits intoopen-telemetry:mainfrom
Conversation
jack-berg
commented
Sep 1, 2022
...ter-1.5/library/src/main/java/io/opentelemetry/instrumentation/micrometer1shim/Bridging.java
Outdated
Show resolved
Hide resolved
mateuszrzeszutek
approved these changes
Sep 2, 2022
...java/io/opentelemetry/instrumentation/micrometer1shim/OpenTelemetryMeterRegistryBuilder.java
Outdated
Show resolved
Hide resolved
LironKS
pushed a commit
to helios/opentelemetry-java-instrumentation
that referenced
this pull request
Oct 23, 2022
* Move micrometer shim library instrumentation back * Switch package to io.opentelemetry.instrumentation.micrometer.v1_5 * Change instrumentation name
LironKS
pushed a commit
to helios/opentelemetry-java-instrumentation
that referenced
this pull request
Oct 31, 2022
* Move micrometer shim library instrumentation back * Switch package to io.opentelemetry.instrumentation.micrometer.v1_5 * Change instrumentation name
LironKS
pushed a commit
to helios/opentelemetry-java-instrumentation
that referenced
this pull request
Dec 4, 2022
* Move micrometer shim library instrumentation back * Switch package to io.opentelemetry.instrumentation.micrometer.v1_5 * Change instrumentation name
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #4661 and in the SIG.
Followup required to incorporate this into the agent.
I went ahead and split out a
testingmodule so that abstract base tests could be reused across the library and agent.