Skip to content

Rename two package-private instrumenter-api classes #6579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
laurit merged 1 commit into from
Sep 12, 2022
Merged

Rename two package-private instrumenter-api classes #6579

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .../src/main/java/io/opentelemetry/instrumentation/api/instrumenter/InstrumenterBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,12 +301,12 @@ static <RQ, RS> InstrumenterConstructor<RQ, RS> internal() {

static <RQ, RS> InstrumenterConstructor<RQ, RS> propagatingToDownstream(
TextMapSetter<RQ> setter) {
return builder -> new ClientInstrumenter<>(builder, setter);
return builder -> new PropagatingToDownstreamInstrumenter<>(builder, setter);
}

static <RQ, RS> InstrumenterConstructor<RQ, RS> propagatingFromUpstream(
TextMapGetter<RQ> getter) {
return builder -> new ServerInstrumenter<>(builder, getter);
return builder -> new PropagatingFromUpstreamInstrumenter<>(builder, getter);
}
}
}
5 changes: 3 additions & 2 deletions .../api/instrumenter/ServerInstrumenter.java → .../PropagatingFromUpstreamInstrumenter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,13 @@
import io.opentelemetry.context.propagation.TextMapGetter;
import io.opentelemetry.instrumentation.api.internal.ContextPropagationDebug;

final class ServerInstrumenter<REQUEST, RESPONSE> extends Instrumenter<REQUEST, RESPONSE> {
final class PropagatingFromUpstreamInstrumenter<REQUEST, RESPONSE>
extends Instrumenter<REQUEST, RESPONSE> {

private final ContextPropagators propagators;
private final TextMapGetter<REQUEST> getter;

ServerInstrumenter(
PropagatingFromUpstreamInstrumenter(
InstrumenterBuilder<REQUEST, RESPONSE> builder, TextMapGetter<REQUEST> getter) {
super(builder);
this.propagators = builder.openTelemetry.getPropagators();
Expand Down
5 changes: 3 additions & 2 deletions .../api/instrumenter/ClientInstrumenter.java → .../PropagatingToDownstreamInstrumenter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,12 +9,13 @@
import io.opentelemetry.context.propagation.ContextPropagators;
import io.opentelemetry.context.propagation.TextMapSetter;

final class ClientInstrumenter<REQUEST, RESPONSE> extends Instrumenter<REQUEST, RESPONSE> {
final class PropagatingToDownstreamInstrumenter<REQUEST, RESPONSE>
extends Instrumenter<REQUEST, RESPONSE> {

private final ContextPropagators propagators;
private final TextMapSetter<REQUEST> setter;

ClientInstrumenter(
PropagatingToDownstreamInstrumenter(
InstrumenterBuilder<REQUEST, RESPONSE> builder, TextMapSetter<REQUEST> setter) {
super(builder);
this.propagators = builder.openTelemetry.getPropagators();
Expand Down