Use ConditionalResourceProvider in the Spring Boot service name provider#6587
Merged
trask merged 5 commits intoopen-telemetry:mainfrom Sep 13, 2022
Merged
Conversation
mateuszrzeszutek
force-pushed
the
spring-boot-conditional-resource
branch
from
c179b37 to
0ee6600
Compare
laurit
approved these changes
Sep 12, 2022
trask
approved these changes
Sep 12, 2022
...ain/java/io/opentelemetry/instrumentation/spring/resources/SpringBootServiceNameGuesser.java
Show resolved
Hide resolved
breedx-splk
approved these changes
Sep 12, 2022
Contributor
breedx-splk
left a comment
breedx-splk
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks for following this up.
mateuszrzeszutek
force-pushed
the
spring-boot-conditional-resource
branch
from
d3bfe50 to
991e8f2
Compare
LironKS
pushed a commit
to helios/opentelemetry-java-instrumentation
that referenced
this pull request
Oct 23, 2022
…der (open-telemetry#6587) * Use ConditionalResourceProvider in the Spring Boot service name provider * make it a bit simpler * add order=100 * add comment * spellcheck
LironKS
pushed a commit
to helios/opentelemetry-java-instrumentation
that referenced
this pull request
Oct 31, 2022
…der (open-telemetry#6587) * Use ConditionalResourceProvider in the Spring Boot service name provider * make it a bit simpler * add order=100 * add comment * spellcheck
LironKS
pushed a commit
to helios/opentelemetry-java-instrumentation
that referenced
this pull request
Dec 4, 2022
…der (open-telemetry#6587) * Use ConditionalResourceProvider in the Spring Boot service name provider * make it a bit simpler * add order=100 * add comment * spellcheck
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.