Implement aws.ecs.* resource attributes#4670
Closed
mmanciop wants to merge 1 commit intoopen-telemetry:mainfrom
Closed
Implement aws.ecs.* resource attributes#4670mmanciop wants to merge 1 commit intoopen-telemetry:mainfrom
mmanciop wants to merge 1 commit intoopen-telemetry:mainfrom
Conversation
Add to io.opentelemetry.sdk.extension.aws.resource.EcsResource the logic to detect the aws.ecs resource attributes from the Amazon ECS Metadata v4 endpoint.
Codecov Report
@@ Coverage Diff @@
## main #4670 +/- ##
============================================
- Coverage 90.13% 90.12% -0.02%
Complexity 5069 5069
============================================
Files 584 584
Lines 15649 15649
Branches 1503 1503
============================================
- Hits 14106 14103 -3
- Misses 1091 1092 +1
- Partials 452 454 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Member
|
@jeromeinsf could you help us find someone from AWS that could review this PR? |
Contributor
|
@willarmiros Can you review this? |
Contributor
Author
|
@willarmiros #4574 does not implement |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add to
io.opentelemetry.sdk.extension.aws.resource.EcsResourcethe logic to detect theaws.ecs.*resource attributes using data from the Amazon ECS Metadata v4 endpoint.