Extended onEnd to allow for explicit calling of next span processor#6394
Closed
JonasKunz wants to merge 2 commits intoopen-telemetry:mainfrom
Closed
Extended onEnd to allow for explicit calling of next span processor#6394JonasKunz wants to merge 2 commits intoopen-telemetry:mainfrom
JonasKunz wants to merge 2 commits intoopen-telemetry:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #6367. This PR adds a new parameter to the
onEndcallback: A function to explicitly invoke the nextSpanProcessorwith aReadableSpan. This allowsSpanProcessorsto modify the span by wrapping it.In contrast to #6367, this approach is a bit more flexible would also allow to filter or buffer and delay spans if needed.
This change is backwards compatible.