feat(mysql): Metrics for mysql#1220
Merged
dyladan merged 81 commits intoopen-telemetry:mainfrom Jan 4, 2023
Merged
Conversation
haddasbronfman
changed the title
…emetry-js-contrib into add-mysql-metrics
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1220 +/- ##
==========================================
- Coverage 96.08% 95.93% -0.15%
==========================================
Files 14 17 +3
Lines 893 1157 +264
Branches 191 231 +40
==========================================
+ Hits 858 1110 +252
- Misses 35 47 +12
|
…emetry-js-contrib into add-mysql-metrics
…emetry-js-contrib into add-mysql-metrics
…emetry-js-contrib into add-mysql-metrics
pichlermarc
reviewed
Dec 13, 2022
Member
pichlermarc
left a comment
pichlermarc
left a comment
There was a problem hiding this comment.
This is looking great already 🙂
Just a few nits + comments from my side.
Thank you for taking the time to work on this 🙂
plugins/node/opentelemetry-instrumentation-mysql/src/instrumentation.ts
Outdated
Show resolved
Hide resolved
osherv
reviewed
Dec 15, 2022
plugins/node/opentelemetry-instrumentation-mysql/src/instrumentation.ts
Outdated
Show resolved
Hide resolved
…emetry-js-contrib into add-mysql-metrics
dyladan
approved these changes
Dec 29, 2022
Member
dyladan
left a comment
dyladan
left a comment
There was a problem hiding this comment.
LGTM. Minor nit on the readme/docs but the impl looks good
| # Overview | ||
|
|
||
| OpenTelemetry MySQL Instrumentation allows the user to automatically collect trace data and export them to the backend of choice (we can use Zipkin or Jaeger for this example), to give observability to distributed systems. | ||
| OpenTelemetry MySQL Instrumentation allows the user to automatically collect trace data and metrics (currently only the number of connections is supported) and export them to the backend of choice (we can use Zipkin, Jaeger or Grafana for this example), to give observability to distributed systems. |
Member
There was a problem hiding this comment.
People may not notice this in the prose when they are using or when they modify the instrumentation. I would just leave it as "trace data and metrics" and link to a list of supported metrics in another heading.
Member
Author
There was a problem hiding this comment.
thanks. I'll fix that.
pichlermarc
approved these changes
Jan 2, 2023
Member
pichlermarc
left a comment
pichlermarc
left a comment
There was a problem hiding this comment.
Great work! Thank you for adding this 🙂
Merged
9 tasks
1 task
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
fixes #1176
Short description of the changes
Add the metric
db.client.connections.usageto mysql according to this: https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/semantic_conventions/database-metrics.md#connection-pools