feat(instrumentation-runtime-node): emit logs for uncaught exceptions#3379
feat(instrumentation-runtime-node): emit logs for uncaught exceptions#3379iblancasa wants to merge 12 commits intoopen-telemetry:mainfrom
Conversation
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
trentm
left a comment
There was a problem hiding this comment.
Thanks for the PR. I have some reservations about unhandledRejection in comments below.
I haven't reviewed the particular log record details yet. Please take a look at #6385 merged just recently (after you created this PR). The Logs SDK spec now includes a mechanism for including an exception. I think this wiould be an obvious candidate to use that.
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
Yes. I implemented that PR. I guess I have to wait for a new release, right? Maybe we can start working on this one in the meantime. Even create a follow up PR to migrate to that mechanism if we are able to make this one happen before. |
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
Which problem is this PR solving?
Fixes #3376