Skip to content

feat(instrumentation-runtime-node): emit logs for uncaught exceptions#3379

Open
iblancasa wants to merge 12 commits intoopen-telemetry:mainfrom
iblancasa:3376
Open

feat(instrumentation-runtime-node): emit logs for uncaught exceptions#3379
iblancasa wants to merge 12 commits intoopen-telemetry:mainfrom
iblancasa:3376

Conversation

@iblancasa
Copy link

@iblancasa iblancasa commented Feb 10, 2026

Which problem is this PR solving?

Fixes #3376

Signed-off-by: Israel Blancas <iblancasa@gmail.com>
@iblancasa iblancasa requested a review from a team as a code owner February 10, 2026 08:41
@github-actions github-actions bot requested a review from d4nyll February 10, 2026 08:41
@iblancasa iblancasa changed the title Emit logs for uncaught exceptions and unhandled rejections feat(instrumentation-runtime-node): emit logs for uncaught exceptions and unhandled rejections Feb 10, 2026
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
Copy link
Contributor

@trentm trentm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I have some reservations about unhandledRejection in comments below.

I haven't reviewed the particular log record details yet. Please take a look at #6385 merged just recently (after you created this PR). The Logs SDK spec now includes a mechanism for including an exception. I think this wiould be an obvious candidate to use that.

@iblancasa iblancasa changed the title feat(instrumentation-runtime-node): emit logs for uncaught exceptions and unhandled rejections feat(instrumentation-runtime-node): emit logs for uncaught exceptions Feb 23, 2026
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
@iblancasa iblancasa marked this pull request as ready for review February 23, 2026 16:08
@iblancasa
Copy link
Author

I haven't reviewed the particular log record details yet. Please take a look at #6385 merged just recently (after you created this PR). The Logs SDK spec now includes a mechanism for including an exception. I think this wiould be an obvious candidate to use that.

Yes. I implemented that PR. I guess I have to wait for a new release, right? Maybe we can start working on this one in the meantime. Even create a follow up PR to migrate to that mechanism if we are able to make this one happen before.

Signed-off-by: Israel Blancas <iblancasa@gmail.com>
Signed-off-by: Israel Blancas <iblancasa@gmail.com>
@iblancasa iblancasa requested review from pichlermarc and trentm March 5, 2026 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Capture uncaught exceptions and emit a log message

5 participants