test(sampler-aws-xray): stabilize flaky setTimeout intervals under CI load#3439
Open
Sigmabrogz wants to merge 1 commit intoopen-telemetry:mainfrom
Open
test(sampler-aws-xray): stabilize flaky setTimeout intervals under CI load#3439Sigmabrogz wants to merge 1 commit intoopen-telemetry:mainfrom
Sigmabrogz wants to merge 1 commit intoopen-telemetry:mainfrom
Conversation
… load Fixes open-telemetry#3394 Increased the terminal setTimeout bounds from 500ms to 1000ms within remote-sampler.test.ts. This gives the internal fetchSamplingRules callback queue sufficient padding to drain across the event loop without artificially slowing down the fast-path passes, effectively stabilizing the test under noisy neighbor CI environments. Made-with: Cursor
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3394
Problem
In recent days, there has been an uptick in flaky tests in
@opentelemetry/sampler-aws-xray. Specifically, the tests inremote-sampler.test.tsdepend onsetTimeoutarrays to wait for internal network mocks (nock) to resolve and forsinonfake timer clocks to cycle. Under heavy CI load, the default 500ms bounds are too tight, causing thesetTimeoutassertion checks to fire before the internal simulated state has fully updated, leading to random test failures.Fix
setTimeoutbounds from 500ms to 1000ms withinremote-sampler.test.ts.fetchSamplingRulescallback queue sufficient padding to drain across the event loop without artificially slowing down the fast-path passes, effectively stabilizing the test under noisy neighbor CI environments.I ran the test suite locally multiple times and the sampler suite passes cleanly now.
This PR was created with AI assistance.
Made with Cursor