chore!: split metrics into its own api package#1797
Merged
dyladan merged 14 commits intoopen-telemetry:masterfrom Jan 15, 2021
Merged
chore!: split metrics into its own api package#1797dyladan merged 14 commits intoopen-telemetry:masterfrom
dyladan merged 14 commits intoopen-telemetry:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1797 +/- ##
==========================================
+ Coverage 92.12% 92.61% +0.49%
==========================================
Files 163 174 +11
Lines 5484 6042 +558
Branches 1177 1283 +106
==========================================
+ Hits 5052 5596 +544
- Misses 432 446 +14
|
Member
Author
|
@open-telemetry/javascript-approvers this is extremely important for the API release so please review. |
vmarchaud
reviewed
Jan 11, 2021
mwear
approved these changes
Jan 12, 2021
obecny
reviewed
Jan 12, 2021
Member
obecny
left a comment
There was a problem hiding this comment.
overall lgtm, many changes :).
Can we have a new folder "types" inside api metrics and then move there all interfaces ? Currently we have interfaces and noop Implementations together in main folder, this could help organise stuff WDYT ?
Member
Author
|
@obecny made all requested changes |
vmarchaud
approved these changes
Jan 13, 2021
dyladan
added a commit
to dyladan/opentelemetry-js
that referenced
this pull request
Sep 9, 2022
dyladan
added a commit
to dyladan/opentelemetry-js
that referenced
this pull request
Sep 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create new
@opentelemetry/metrics-apipackageFollow up:
api-commonpackage for shared things like logging interface?api-metricsjust depends onapito get these things.