More specific api type names#1874
Merged
dyladan merged 7 commits intoopen-telemetry:mainfrom Feb 4, 2021
Merged
Conversation
- AttributeValue => SpanAttributeValue - Attributes => SpanAttributes - EntryTtl => BaggageEntryTtl - EntryValue => BaggageEntryValue - Status => SpanStatus - StatusCode => SpanStatusCode
Codecov Report
@@ Coverage Diff @@
## main #1874 +/- ##
==========================================
- Coverage 92.72% 92.37% -0.36%
==========================================
Files 174 157 -17
Lines 6038 5104 -934
Branches 1283 1085 -198
==========================================
- Hits 5599 4715 -884
+ Misses 439 389 -50
|
MSNev
approved these changes
Jan 27, 2021
vmarchaud
reviewed
Jan 27, 2021
Member
vmarchaud
left a comment
There was a problem hiding this comment.
I expected before that both span/metrics would share the same attributes types, is this a first step to be able to seperate them later on ?
Member
|
This PR should be mentioned in https://github.com/open-telemetry/opentelemetry-js#upgrade-guidelines |
Member
Author
That is not the case at the moment. |
vmarchaud
approved these changes
Jan 28, 2021
Flarna
approved these changes
Jan 28, 2021
obecny
approved these changes
Feb 1, 2021
Member
obecny
left a comment
There was a problem hiding this comment.
pls update upgrade guidelines to 0.17
dyladan
added a commit
to dyladan/opentelemetry-js
that referenced
this pull request
Sep 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.