fix: specification compliant resource collision precedence#1975
Merged
dyladan merged 6 commits intoopen-telemetry:mainfrom Mar 2, 2021
Merged
fix: specification compliant resource collision precedence#1975dyladan merged 6 commits intoopen-telemetry:mainfrom
dyladan merged 6 commits intoopen-telemetry:mainfrom
Conversation
srikanthccv
requested review from
Flarna,
OlivierAlbertini,
dyladan,
johnbley,
legendecas,
markwolff,
mayurkale22,
mwear,
naseemkullah,
obecny and
vmarchaud
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1975 +/- ##
==========================================
+ Coverage 92.87% 92.92% +0.05%
==========================================
Files 152 152
Lines 5922 5922
Branches 1245 1245
==========================================
+ Hits 5500 5503 +3
+ Misses 422 419 -3
|
vmarchaud
approved these changes
Feb 28, 2021
Flarna
approved these changes
Mar 1, 2021
Member
|
Can you add this to the upgrade guidelines in the README since it is a breaking change? |
johnbley
approved these changes
Mar 1, 2021
Member
Author
|
@dyladan I have added the new entry. |
dyladan
reviewed
Mar 1, 2021
Co-authored-by: Daniel Dyla <dyladan@users.noreply.github.com>
dyladan
changed the title
dyladan
approved these changes
Mar 1, 2021
Member
|
Looks good but I want to wait for @obecny since this PR is only 1 day old and it was a weekend |
obecny
approved these changes
Mar 1, 2021
Member
obecny
left a comment
obecny
left a comment
There was a problem hiding this comment.
lgtm,
one comment, hope you can address it before merge.
Co-authored-by: Bartlomiej Obecny <bobecny@gmail.com>
This was referenced Mar 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resource Merge Spec
This commit updates the resource collision precedence.