fix: update typescript getting-started tracing example and docs#2504
Merged
dyladan merged 2 commits intoopen-telemetry:mainfrom Sep 29, 2021
Merged
Conversation
dyladan
approved these changes
Sep 28, 2021
Member
dyladan
left a comment
dyladan
left a comment
There was a problem hiding this comment.
This looks like a good change to me, but the decision has been made that we should maintain the getting_started in the website docs. I'm going to approve this because it is an improvement, but you should know these changes would be better ported over there.
Codecov Report
@@ Coverage Diff @@
## main #2504 +/- ##
=======================================
Coverage 93.23% 93.23%
=======================================
Files 137 137
Lines 5042 5042
Branches 1066 1066
=======================================
Hits 4701 4701
Misses 341 341 |
Flarna
approved these changes
Sep 29, 2021
6 tasks
This was referenced May 26, 2023
[Snyk] Upgrade @opentelemetry/exporter-jaeger from 0.25.0 to 0.26.0
0xETHengineer/opentelemetry-js#2
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Short description of the changes