chore: fix build errors#747
Merged
mayurkale22 merged 2 commits intoopen-telemetry:masterfrom Feb 5, 2020
Merged
Conversation
Member
|
I'm reviewing this and on my branch I did exactly the same thing (without changing tdd script) and I get the same issue... |
Member
Author
|
looking into it |
This was referenced Jan 30, 2020
ccfa941 to
7760b3a
Compare
Codecov Report
@@ Coverage Diff @@
## master #747 +/- ##
=========================================
+ Coverage 96.22% 96.5% +0.27%
=========================================
Files 208 67 -141
Lines 9488 1603 -7885
Branches 809 131 -678
=========================================
- Hits 9130 1547 -7583
+ Misses 358 56 -302
|
Member
Author
|
@open-telemetry/javascript-approvers I know this has had a lot of updates but I just squashed it all down into two commits. Please take a look and review. |
vmarchaud
approved these changes
Feb 4, 2020
mayurkale22
reviewed
Feb 4, 2020
mayurkale22
reviewed
Feb 4, 2020
mayurkale22
reviewed
Feb 4, 2020
Member
mayurkale22
left a comment
There was a problem hiding this comment.
Nice work, thanks for fixing the build.
mayurkale22
approved these changes
Feb 4, 2020
markwolff
approved these changes
Feb 5, 2020
Closed
dyladan
added a commit
to dyladan/opentelemetry-js
that referenced
this pull request
Sep 9, 2022
* chore: switch from yarn to npm * chore: ignore unpublished package
pichlermarc
pushed a commit
to dynatrace-oss-contrib/opentelemetry-js
that referenced
this pull request
Dec 15, 2023
* chore: switch from yarn to npm * chore: ignore unpublished package
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue that prevented lerna from being used on node 8.todo: create a follow up PR that removes the skip of the broken link after it is published to npm #751