update examples and getting started for provider and api package#750
Merged
mayurkale22 merged 7 commits intoopen-telemetry:masterfrom Feb 5, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #750 +/- ##
==========================================
+ Coverage 90.88% 95.87% +4.98%
==========================================
Files 233 160 -73
Lines 10438 6260 -4178
Branches 965 498 -467
==========================================
- Hits 9487 6002 -3485
+ Misses 951 258 -693
|
Member
Author
|
@open-telemetry/javascript-approvers please review this. Until it is merged examples, getting started, and benchmark are all failing on master. |
mayurkale22
reviewed
Feb 4, 2020
Member
mayurkale22
left a comment
There was a problem hiding this comment.
Added a few comments, looks like we are still using core instead of api module esp. init provider and get tracer.
vmarchaud
approved these changes
Feb 4, 2020
mayurkale22
approved these changes
Feb 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.