Skip to content

update examples and getting started for provider and api package#750

Merged
mayurkale22 merged 7 commits intoopen-telemetry:masterfrom
dynatrace-oss-contrib:rename-provider-examples
Feb 5, 2020
Merged

update examples and getting started for provider and api package#750
mayurkale22 merged 7 commits intoopen-telemetry:masterfrom
dynatrace-oss-contrib:rename-provider-examples

Conversation

@dyladan
Copy link
Copy Markdown
Member

@dyladan dyladan commented Jan 29, 2020

  • Finishes the provider rename in examples and getting started
  • Updates examples and getting started for api package update

@dyladan dyladan changed the title chore: rename provider in examples and getting started update examples and getting started for provider and api package Jan 29, 2020
@codecov-io
Copy link
Copy Markdown

codecov-io commented Jan 29, 2020

Codecov Report

Merging #750 into master will increase coverage by 4.98%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #750      +/-   ##
==========================================
+ Coverage   90.88%   95.87%   +4.98%     
==========================================
  Files         233      160      -73     
  Lines       10438     6260    -4178     
  Branches      965      498     -467     
==========================================
- Hits         9487     6002    -3485     
+ Misses        951      258     -693
Impacted Files Coverage Δ
...in-postgres/opentelemetry-plugin-pg/src/version.ts 100% <0%> (ø) ⬆️
packages/opentelemetry-core/src/common/types.ts 100% <0%> (ø) ⬆️
...kages/opentelemetry-plugin-dns/test/utils/utils.ts 33.33% <0%> (-26.67%) ⬇️
.../opentelemetry-core/src/trace/spancontext-utils.ts 100% <0%> (ø) ⬆️
packages/opentelemetry-core/src/utils/url.ts 100% <0%> (ø) ⬆️
packages/opentelemetry-plugin-redis/src/version.ts 100% <0%> (ø) ⬆️
...pentelemetry-core/src/platform/node/performance.ts 100% <0%> (ø) ⬆️
...ckages/opentelemetry-plugin-ioredis/src/version.ts 100% <0%> (ø) ⬆️
...metry-core/src/trace/instrumentation/BasePlugin.ts 81.57% <0%> (-5.27%) ⬇️
...-plugin-postgres/opentelemetry-plugin-pg/src/pg.ts 91.52% <0%> (ø) ⬆️
... and 187 more

@OlivierAlbertini OlivierAlbertini added the document Documentation-related label Jan 30, 2020
@dyladan
Copy link
Copy Markdown
Member Author

dyladan commented Feb 4, 2020

@open-telemetry/javascript-approvers please review this. Until it is merged examples, getting started, and benchmark are all failing on master.

Copy link
Copy Markdown
Member

@mayurkale22 mayurkale22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few comments, looks like we are still using core instead of api module esp. init provider and get tracer.

Comment thread examples/ioredis/tracer.js Outdated
Comment thread getting-started/ts-example/README.md Outdated
Comment thread examples/basic-tracer-node/index.js Outdated
Comment thread examples/basic-tracer-node/index.js Outdated
Copy link
Copy Markdown
Member

@mayurkale22 mayurkale22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mayurkale22 mayurkale22 added Merge:LGTM This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.) needs-rebase labels Feb 4, 2020
@mayurkale22 mayurkale22 merged commit c5bc438 into open-telemetry:master Feb 5, 2020
@Flarna Flarna deleted the rename-provider-examples branch February 11, 2020 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

document Documentation-related Merge:LGTM This PR is ready to be merged by a Maintainer (has enough valid approvals, successful build, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants