Skip to content

[opentelemetry-auto-slim] fix schema url#270

Merged
brettmc merged 3 commits intoopen-telemetry:mainfrom
weslenteche:fix/slim-schema-url
Jun 18, 2024
Merged

[opentelemetry-auto-slim] fix schema url#270
brettmc merged 3 commits intoopen-telemetry:mainfrom
weslenteche:fix/slim-schema-url

Conversation

@weslenteche
Copy link
Copy Markdown
Contributor

This pull request aims to fix an issue identified in which the value of schemaUrl is being inferred in the $version parameter instead of $schemaUrl

@weslenteche weslenteche requested a review from a team June 13, 2024 23:43
@weslenteche weslenteche changed the title [opentelemetry-php-auto-slim] fix schema url [opentelemetry-auto-slim] fix schema url Jun 13, 2024
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 13, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 83.53%. Comparing base (00bf8ba) to head (2641cd6).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #270      +/-   ##
============================================
- Coverage     83.59%   83.53%   -0.06%     
  Complexity     1057     1057              
============================================
  Files           104      104              
  Lines          4389     4392       +3     
============================================
  Hits           3669     3669              
- Misses          720      723       +3     
Flag Coverage Δ
Aws:7.4 86.02% <ø> (ø)
Aws:8.0 85.75% <ø> (ø)
Aws:8.1 85.75% <ø> (ø)
Aws:8.2 85.75% <ø> (ø)
Aws:8.3 85.75% <ø> (ø)
Context/Swoole:7.4 0.00% <ø> (ø)
Context/Swoole:8.0 0.00% <ø> (ø)
Context/Swoole:8.1 0.00% <ø> (ø)
Context/Swoole:8.2 0.00% <ø> (ø)
Context/Swoole:8.3 0.00% <ø> (ø)
Instrumentation/CakePHP:8.0 93.47% <ø> (ø)
Instrumentation/CakePHP:8.1 93.47% <ø> (ø)
Instrumentation/CakePHP:8.2 93.47% <ø> (ø)
Instrumentation/CakePHP:8.3 93.47% <ø> (ø)
Instrumentation/CodeIgniter:8.0 75.86% <ø> (ø)
Instrumentation/CodeIgniter:8.1 75.86% <ø> (ø)
Instrumentation/CodeIgniter:8.2 75.86% <ø> (ø)
Instrumentation/CodeIgniter:8.3 75.86% <ø> (ø)
Instrumentation/ExtAmqp:8.2 89.58% <ø> (ø)
Instrumentation/ExtAmqp:8.3 89.58% <ø> (ø)
Instrumentation/Guzzle:8.0 72.60% <ø> (ø)
Instrumentation/Guzzle:8.1 72.60% <ø> (ø)
Instrumentation/Guzzle:8.2 72.60% <ø> (ø)
Instrumentation/Guzzle:8.3 72.60% <ø> (ø)
Instrumentation/HttpAsyncClient:8.0 81.33% <ø> (ø)
Instrumentation/HttpAsyncClient:8.1 81.33% <ø> (ø)
Instrumentation/HttpAsyncClient:8.2 81.33% <ø> (ø)
Instrumentation/HttpAsyncClient:8.3 81.33% <ø> (ø)
Instrumentation/IO:8.2 75.00% <ø> (ø)
Instrumentation/IO:8.3 75.00% <ø> (ø)
Instrumentation/Laravel:8.0 65.20% <ø> (ø)
Instrumentation/Laravel:8.1 65.20% <ø> (ø)
Instrumentation/Laravel:8.2 65.20% <ø> (ø)
Instrumentation/Laravel:8.3 65.20% <ø> (ø)
Instrumentation/MongoDB:7.4 80.55% <ø> (ø)
Instrumentation/MongoDB:8.0 80.55% <ø> (ø)
Instrumentation/MongoDB:8.1 80.55% <ø> (ø)
Instrumentation/MongoDB:8.2 80.55% <ø> (ø)
Instrumentation/MongoDB:8.3 80.55% <ø> (ø)
Instrumentation/OpenAIPHP:8.1 86.82% <ø> (ø)
Instrumentation/OpenAIPHP:8.2 86.82% <ø> (ø)
Instrumentation/OpenAIPHP:8.3 86.82% <ø> (ø)
Instrumentation/PDO:8.2 97.46% <ø> (ø)
Instrumentation/PDO:8.3 97.46% <ø> (ø)
Instrumentation/Psr14:8.0 80.64% <ø> (ø)
Instrumentation/Psr14:8.1 80.64% <ø> (ø)
Instrumentation/Psr14:8.2 80.64% <ø> (ø)
Instrumentation/Psr14:8.3 80.64% <ø> (ø)
Instrumentation/Psr15:8.0 93.50% <ø> (ø)
Instrumentation/Psr15:8.1 93.50% <ø> (ø)
Instrumentation/Psr15:8.2 93.50% <ø> (ø)
Instrumentation/Psr15:8.3 93.50% <ø> (ø)
Instrumentation/Psr16:8.0 97.50% <ø> (ø)
Instrumentation/Psr16:8.1 97.50% <ø> (ø)
Instrumentation/Psr16:8.2 97.50% <ø> (ø)
Instrumentation/Psr16:8.3 97.50% <ø> (ø)
Instrumentation/Psr18:8.0 82.08% <ø> (ø)
Instrumentation/Psr18:8.1 82.08% <ø> (ø)
Instrumentation/Psr18:8.2 82.08% <ø> (ø)
Instrumentation/Psr18:8.3 82.08% <ø> (ø)
Instrumentation/Psr3:8.0 63.51% <ø> (ø)
Instrumentation/Psr3:8.1 63.51% <ø> (ø)
Instrumentation/Psr3:8.2 63.51% <ø> (ø)
Instrumentation/Psr3:8.3 63.51% <ø> (ø)
Instrumentation/Psr6:8.0 97.61% <ø> (ø)
Instrumentation/Psr6:8.1 97.61% <ø> (ø)
Instrumentation/Psr6:8.2 97.61% <ø> (ø)
Instrumentation/Psr6:8.3 97.61% <ø> (ø)
Instrumentation/Slim:8.0 86.23% <0.00%> (-1.92%) ⬇️
Instrumentation/Slim:8.1 86.95% <0.00%> (-1.94%) ⬇️
Instrumentation/Slim:8.2 86.95% <0.00%> (-1.94%) ⬇️
Instrumentation/Slim:8.3 86.95% <0.00%> (-1.94%) ⬇️
Instrumentation/Symfony:8.0 94.83% <ø> (ø)
Instrumentation/Symfony:8.1 94.83% <ø> (ø)
Instrumentation/Symfony:8.2 94.83% <ø> (ø)
Instrumentation/Symfony:8.3 94.83% <ø> (ø)
Instrumentation/Yii:8.0 79.82% <ø> (ø)
Instrumentation/Yii:8.1 79.82% <ø> (ø)
Instrumentation/Yii:8.2 79.82% <ø> (ø)
Instrumentation/Yii:8.3 79.82% <ø> (ø)
Logs/Monolog:7.4 100.00% <ø> (ø)
Logs/Monolog:8.0 100.00% <ø> (ø)
Logs/Monolog:8.1 100.00% <ø> (ø)
Logs/Monolog:8.2 100.00% <ø> (ø)
Logs/Monolog:8.3 100.00% <ø> (ø)
Propagation/ServerTiming:8.0 100.00% <ø> (ø)
Propagation/ServerTiming:8.1 100.00% <ø> (ø)
Propagation/ServerTiming:8.2 100.00% <ø> (ø)
Propagation/ServerTiming:8.3 100.00% <ø> (ø)
Propagation/TraceResponse:7.4 100.00% <ø> (ø)
Propagation/TraceResponse:8.0 100.00% <ø> (ø)
Propagation/TraceResponse:8.1 100.00% <ø> (ø)
Propagation/TraceResponse:8.2 100.00% <ø> (ø)
Propagation/TraceResponse:8.3 100.00% <ø> (ø)
ResourceDetectors/Azure:7.4 91.66% <ø> (ø)
ResourceDetectors/Azure:8.0 91.66% <ø> (ø)
ResourceDetectors/Azure:8.1 91.66% <ø> (ø)
ResourceDetectors/Azure:8.2 91.66% <ø> (ø)
ResourceDetectors/Azure:8.3 91.66% <ø> (ø)
ResourceDetectors/Container:8.0 93.02% <ø> (ø)
ResourceDetectors/Container:8.1 93.02% <ø> (ø)
ResourceDetectors/Container:8.2 93.02% <ø> (ø)
ResourceDetectors/Container:8.3 93.02% <ø> (ø)
Shims/OpenTracing:7.4 92.99% <ø> (ø)
Shims/OpenTracing:8.0 92.99% <ø> (ø)
Shims/OpenTracing:8.1 92.99% <ø> (ø)
Shims/OpenTracing:8.2 92.99% <ø> (ø)
Shims/OpenTracing:8.3 92.99% <ø> (ø)
Symfony:7.4 88.43% <ø> (ø)
Symfony:8.0 88.20% <ø> (ø)
Symfony:8.1 88.20% <ø> (ø)
Symfony:8.2 88.20% <ø> (ø)
Symfony:8.3 88.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...c/Instrumentation/Slim/src/SlimInstrumentation.php 87.00% <0.00%> (-2.70%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 00bf8ba...2641cd6. Read the comment docs.

@brettmc
Copy link
Copy Markdown
Contributor

brettmc commented Jun 14, 2024

The named params don't work with 8.0. The usage of this package for 8.0 is <1%, so I'm happy for either dropping 8.0 (update composer requirements and drop it from the build matrix), or maintaining support for a bit longer by not using named params.

@weslenteche
Copy link
Copy Markdown
Contributor Author

weslenteche commented Jun 14, 2024

The named params don't work with 8.0. The usage of this package for 8.0 is <1%, so I'm happy for either dropping 8.0 (update composer requirements and drop it from the build matrix), or maintaining support for a bit longer by not using named params.

I opted for the second option, so I removed the named parameters.

@brettmc
Copy link
Copy Markdown
Contributor

brettmc commented Jun 15, 2024

I opted for the second option, so I removed the named parameters.

The change LGTM, however there are now psalm failures.

@weslenteche
Copy link
Copy Markdown
Contributor Author

I opted for the second option, so I removed the named parameters.

The change LGTM, however there are now psalm failures.

Could you help me resolve the psalm errors?

I tried to add extends to the params template code in this code snippet, but without success.

@agoallikmaa
Copy link
Copy Markdown
Contributor

Could you help me resolve the psalm errors?

I tried to add extends to the params template code in this code snippet, but without success.

Slim added some psalm template annotations in 4.14.0. Trying to replicate the annotations they use internally (@template-extends) doesn't seem to be detected by psalm, not sure if it's because of the anonymous declaration, but it can be suppressed with @psalm-suppress MissingTemplateParam before that line.

@brettmc brettmc merged commit ac524f9 into open-telemetry:main Jun 18, 2024
@weslenteche weslenteche deleted the fix/slim-schema-url branch June 18, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants