use sqlalchemy module name not engine. fixes #922#1086
Merged
srikanthccv merged 3 commits intoopen-telemetry:mainfrom May 11, 2022
Merged
use sqlalchemy module name not engine. fixes #922#1086srikanthccv merged 3 commits intoopen-telemetry:mainfrom
srikanthccv merged 3 commits intoopen-telemetry:mainfrom
Conversation
08d3823 to
8c82330
Compare
srikanthccv
approved these changes
May 10, 2022
Member
Where it is used, it's just a single file and there is no difference b/w |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bug fix for module name emitted by sqlalchemy.
Other instrumentation libraries appear to be calling
get_tracerwith__name__but the API docs seems to recommend against this.Fixes #922
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
instrumentation_scope.nameDoes This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.