Add span for connection phase

[shahargl]

Description

I've added the code that adds #1133

Fixes #1133
#1133

Type of change

Please delete options that are not relevant.

• New feature (non-breaking change which adds functionality)

Does This PR Require a Core Repo Change?

• No.

Checklist:

See contributing.md for styleguide, changelog guidelines, and more.

• Followed the style guidelines of this project
• Changelogs have been updated
• Unit tests have been added
• Documentation has been updated

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: shahargl (886ce6a)

[ocelotl]

Thanks for the contribution! We need at least one test case that validates these changes are correct 🙂

[shahargl]

@ocelotl no problem!

We need at least one test case that validates these changes are correct

Can you guide me through an example? You mean UT?

Also, I saw that some tests are failing now so I'll fix it

[shahargl]

@ocelotl Fixed all tests and they pass now. Also - they're covering the connect phase, as every test use engine.connect (you can see the number of spans is now 2 instead of 1)

[shahargl]

@ocelotl
Added also a test for connection phase

[srikanthccv]

you probably wanted to add listen on connect similar to this

opentelemetry-python-contrib/instrumentation/opentelemetry-instrumentation-sqlalchemy/src/opentelemetry/instrumentation/sqlalchemy/engine.py

Lines 87 to 91 in 80969a0

	listen(
	engine, "before_cursor_execute", self._before_cur_exec, retval=True
	)
	listen(engine, "after_cursor_execute", _after_cur_exec)
	listen(engine, "handle_error", _handle_error)

[shahargl]

@srikanthccv
Hey! Thanks for jumping in :)

So - initially, I thought about this approach too. Still, the problem is that if I add a listener to the connect event, we will have only the time the connection is initialized. Without having the "connection completed" event, we won't be able to "finish" the span.

Unfortunately, sqlalchemy doesn't have this event (https://docs.sqlalchemy.org/en/14/core/events.html)
So I chose to patch the connect function so the full connection time will be traced. wdyt?

[srikanthccv]

@shahargl makes sense

[shahargl]

@ocelotl updated the code to allow SQLAlchemy 1.1 too

[shahargl]

@ocelotl @srikanthccv - fixed the tests :) feel free to approve/merge

[ocelotl]

@ocelotl @srikanthccv - fixed the tests :) feel free to approve/merge

I see some tests failing, please take a look, @shahargl

[shahargl]

@ocelotl fixed, can you report the status so the tests will run?

[srikanthccv]

LGTM. Minor comments.

[shahargl]

@ocelotl
Thanks again, fixed your comments. Sorry it takes too long, can you rerun the tests?

[shahargl]

@ocelotl
4 tests failing with

17 | #include "codecs.h"
          |          ^~~~~~~~~~
    compilation terminated.
    error: command 'gcc' failed with exit status 1

So idk why, do you have idea?

Also, fixed the docker-tests