DBAPI: Add param to control capturing of db.statement.parameters#156
Merged
lzchen merged 7 commits intoopen-telemetry:masterfrom Nov 10, 2020
Merged
Conversation
stschenk
requested review from
a team,
codeboten and
toumorokoshi
and removed request for
a team
6 tasks
toumorokoshi
approved these changes
Nov 7, 2020
Member
toumorokoshi
left a comment
toumorokoshi
left a comment
There was a problem hiding this comment.
A couple small changes, but LGTM!
instrumentation/opentelemetry-instrumentation-dbapi/CHANGELOG.md
Outdated
Show resolved
Hide resolved
...tion/opentelemetry-instrumentation-dbapi/src/opentelemetry/instrumentation/dbapi/__init__.py
Show resolved
Hide resolved
instrumentation/opentelemetry-instrumentation-dbapi/tests/test_dbapi_integration.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Yusuke Tsutsumi <tsutsumi.yusuke@gmail.com>
lzchen
approved these changes
Nov 9, 2020
lzchen
reviewed
Nov 9, 2020
|
|
||
| - Change package name to opentelemetry-instrumentation-dbapi | ||
| ([#966](https://github.com/open-telemetry/opentelemetry-python/pull/966)) | ||
| ([#156](https://github.com/open-telemetry/opentelemetry-python-contrib/pull/156)) |
Contributor
There was a problem hiding this comment.
Don't think we need this change.
Contributor
Author
There was a problem hiding this comment.
ugh... not sure what I was thinking. Will fix this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Switched DBAPI so that it will not capture parameterized query parameters. Capturing this would be a problem in production environments since they will contain sensitive information such as session tokens and hashed passwords.
Have added a parameter to the instrumentation constructor to allow for this feature to be turned on.
I will mark this as a breaking change since I am removing the db.statement.parameter span attribute and something might be depending on it.
Fixes #157
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: