Comment out aiohttp-server from bootstrap_gen libraries#2299
Closed
tammy-baylis-swi wants to merge 3 commits intoopen-telemetry:mainfrom
Closed
Comment out aiohttp-server from bootstrap_gen libraries#2299tammy-baylis-swi wants to merge 3 commits intoopen-telemetry:mainfrom
tammy-baylis-swi wants to merge 3 commits intoopen-telemetry:mainfrom
Conversation
Contributor
Author
|
Investigating the |
Contributor
Author
|
Closing because can be addressed by this existing PR: #2101 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes
opentelemetry-instrumentation-aiohttp-serverfrom libraries list used to find and install instrumentors that match installed Python frameworks at bootstrap.For example: with Opentelemetry 1.23.0/0.44b0, Python 3.9 and aiohttp 3.9.3 in a test environment, I get
RuntimeErroratopentelemetry-bootstrap:This PR temporarily patches #2053 until PyPI package is made available.
Related to #2258.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
In a python:3.9 docker container, I have a FastAPI app that uses aiohttp 3.9.3. I locally installed a working copy of
opentelemetry-instrumentationand its dependencies (pip install -Ie <dir>). The updatedlibrarieslist stops theRuntimeErrorfrom happening and bootstrap finishes.Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.