Rename "host.port" attribute to "net.host.port"#242
Merged
lzchen merged 7 commits intoopen-telemetry:masterfrom Dec 11, 2020
Merged
Rename "host.port" attribute to "net.host.port"#242lzchen merged 7 commits intoopen-telemetry:masterfrom
lzchen merged 7 commits intoopen-telemetry:masterfrom
Conversation
Signed-off-by: Sergei Malafeev <sergei@malafeev.org>
malafeev
requested review from
a team,
codeboten and
ocelotl
and removed request for
a team
malafeev
changed the title
added 2 commits
December 9, 2020 21:23
Signed-off-by: Sergei Malafeev <sergei@malafeev.org>
Signed-off-by: Sergei Malafeev <sergei@malafeev.org>
codeboten
suggested changes
Dec 9, 2020
Contributor
codeboten
left a comment
codeboten
left a comment
There was a problem hiding this comment.
Minor change to the changelog, otherwise the PR looks great!
CHANGELOG.md
Outdated
| ### Changed | ||
| - `opentelemetry-ext-http-requests` Rename package to opentelemetry-ext-requests | ||
| ([#619](https://github.com/open-telemetry/opentelemetry-python/pull/619)) | ||
| - - `opentelemetry-ext-http-requests` Rename package to opentelemetry-ext-requests |
Contributor
There was a problem hiding this comment.
this looks like a copy and paste typo?
Signed-off-by: Sergei Malafeev <sergei@malafeev.org>
lzchen
approved these changes
Dec 10, 2020
ocelotl
approved these changes
Dec 11, 2020
added 2 commits
December 11, 2020 14:25
# Conflicts: # CHANGELOG.md
…hon-contrib into net.host.port
Author
|
can anybody merge this PR? |
NathanielRN
pushed a commit
to NathanielRN/opentelemetry-python-contrib-1
that referenced
this pull request
Dec 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
According to Semantic Conventions https://github.com/open-telemetry/opentelemetry-specification/blob/master/specification/metrics/semantic_conventions/http-metrics.md
attribute "net.host.port" should be used instead of "host.port"
Fixes #240
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.