Fix net peer attribute for unix socket connection#2493
Merged
lzchen merged 4 commits intoopen-telemetry:mainfrom May 30, 2024
Merged
Fix net peer attribute for unix socket connection#2493lzchen merged 4 commits intoopen-telemetry:mainfrom
lzchen merged 4 commits intoopen-telemetry:mainfrom
Conversation
xrmx
reviewed
May 6, 2024
Contributor
xrmx
left a comment
There was a problem hiding this comment.
Thanks for the PR, please add a test so we can avoid regressions
xrmx
approved these changes
May 9, 2024
Contributor
xrmx
left a comment
There was a problem hiding this comment.
Thanks a lot for adding tests!
Contributor
|
@shadchin care to rebase and add a changelog entry please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
After switch on
.get(...),KeyErrorexception is never raisedType of change
Please delete options that are not relevant.
How Has This Been Tested?
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.