opentelemetry-instrumentation-asgi: always set status code on duration attributes

[danielhochman]

Description

Bug: OpenTelemetryMiddleware records histograms with no status code if the span is non-recording. The decision to include status code on a histogram should not be dependent on tracing decisions.

Type of change

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

• Unit tests

Does This PR Require a Core Repo Change?

• No.

Checklist:

• Followed the style guidelines of this project
• Changelogs have been updated
• Unit tests have been added
• Documentation has been updated

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: lzchen / name: Leighton Chen (c75e732, 392a03b, a1a7250, fd7f9c4, 02ba4f9, 06fffb1, d781e36, 95c008f, 28814fd, e4eedab, 75544b2)
• ✅ login: danielhochman / name: Daniel Hochman (49ed834, 6c65c4a, 8138988, f391a9d, 9f34e8f, 1abb600, 2f24e08)

[xrmx]

@danielhochman You need the CLA signed to get your contribution accepted

[danielhochman]

@xrmx Thanks, was waiting on Corp CLA approval. It's signed now!

[danielhochman]

@xrmx lint should pass now (tested locally), sorry for the churn.

[danielhochman]

@xrmx Thanks again. I think this should be ready to merge!

[danielhochman]

@xrmx Thanks for your review! Are we ready to merge?

[lzchen]

@danielhochman

Recent changes to asgi instrumentation changes has caused some conflicts. I will resolve them by directly committing to your branch.

[emdneto]

Did som runs in some scenarios I have here and it's working as expected:
For old semconv:

{
    "name": "http.server.duration",
    "description": "Duration of HTTP server requests.",
    "unit": "ms",
    "data": {
        "data_points": [
            {
                "attributes": {
                    "http.scheme": "http",
                    "http.host": "127.0.0.1:8000",
                    "net.host.port": 8000,
                    "http.flavor": "1.1",
                    "http.method": "GET",
                    "http.server_name": "localhost:8000",
                    "http.status_code": 500,
                    "http.target": "/foobar"
                },
            }

For new semconv:

{
"name": "http.server.request.duration",
"description": "Duration of HTTP server requests.",
"unit": "s",
"data": {
    "data_points": [
        {
            "attributes": {
                "url.scheme": "http",
                "network.protocol.version": "1.1",
                "http.request.method": "GET",
                "http.route": "/foobar",
                "http.response.status_code": 500,
                "error.type": "500"
}

[Kludex]

If anything... It should be 101, not 200.

[xrmx]

Please open an issue or a PR, I don't think many people will see a comment on a PR closed months ago.