HTTP semantic convention stability migration for fastapi#2682
Merged
lzchen merged 32 commits intoopen-telemetry:mainfrom Jul 12, 2024
Merged
HTTP semantic convention stability migration for fastapi#2682lzchen merged 32 commits intoopen-telemetry:mainfrom
lzchen merged 32 commits intoopen-telemetry:mainfrom
Conversation
xrmx
reviewed
Jul 9, 2024
emdneto
reviewed
Jul 10, 2024
Member
There was a problem hiding this comment.
For reviewers: I did some runs of fastapi instrumentation using this branch and the current version available
Current version (0.46b0) - No opt-in
"attributes": {
"http.scheme": "http",
"http.host": "127.0.0.1:8000",
"net.host.port": 8000,
"http.flavor": "1.1",
"http.target": "/foobar",
"http.url": "http://127.0.0.1:8000/foobar",
"http.method": "GET",
"http.server_name": "localhost:8000",
"http.user_agent": "curl/7.68.0",
"net.peer.ip": "127.0.0.1",
"net.peer.port": 40220,
"http.route": "/foobar",
"http.status_code": 200
},New version 0.47b0.dev (with the changes from this PR)
Default
"attributes": {
"http.scheme": "http",
"http.host": "127.0.0.1:8000",
"net.host.port": 8000,
"http.flavor": "1.1",
"http.target": "/foobar",
"http.url": "http://127.0.0.1:8000/foobar",
"http.method": "GET",
"http.server_name": "localhost:8000",
"http.user_agent": "curl/7.68.0",
"net.peer.ip": "127.0.0.1",
"net.peer.port": 33188,
"http.route": "/foobar",
"http.status_code": 200
},New semconv
"attributes": {
"url.scheme": "http",
"server.address": "127.0.0.1:8000",
"server.port": 8000,
"network.protocol.version": "1.1",
"url.path": "/foobar",
"url.full": "http://127.0.0.1:8000/foobar",
"http.request.method": "GET",
"user_agent.original": "curl/7.68.0",
"client.address": "127.0.0.1",
"client.port": 45854,
"http.route": "/foobar",
"http.response.status_code": 200
},HTTP Dup
"attributes": {
"http.scheme": "http",
"url.scheme": "http",
"http.host": "127.0.0.1:8000",
"server.address": "127.0.0.1:8000",
"net.host.port": 8000,
"server.port": 8000,
"http.flavor": "1.1",
"network.protocol.version": "1.1",
"http.target": "/foobar",
"url.path": "/foobar",
"http.url": "http://127.0.0.1:8000/foobar",
"url.full": "http://127.0.0.1:8000/foobar",
"http.method": "GET",
"http.request.method": "GET",
"http.server_name": "localhost:8000",
"http.user_agent": "curl/7.68.0",
"user_agent.original": "curl/7.68.0",
"net.peer.ip": "127.0.0.1",
"client.address": "127.0.0.1",
"net.peer.port": 49964,
"client.port": 49964,
"http.route": "/foobar",
"http.status_code": 200,
"http.response.status_code": 200
},
Member
|
I have identified two issues that are out of the scope of this PR:
Will create the issues for this |
emdneto
reviewed
Jul 11, 2024
instrumentation/opentelemetry-instrumentation-fastapi/tests/test_fastapi_instrumentation.py
Show resolved
Hide resolved
emdneto
approved these changes
Jul 11, 2024
This was referenced Jul 11, 2024
This was referenced Jul 13, 2024
lzchen
added a commit
that referenced
this pull request
Jul 25, 2024
Left behind erroneously from #2682
xrmx
pushed a commit
to xrmx/opentelemetry-python-contrib
that referenced
this pull request
Jan 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #2453