Deprecate sklearn instrumentation

[ocelotl]

Fixes #2176

[xrmx]

This is more like remove than deprecate, I was thinking that we may drop it when we remove support for python 3.8 maybe?

[ocelotl]

This is more like remove than deprecate, I was thinking that we may drop it when we remove support for python 3.8 maybe?

This is deprecation. We no longer will publish it, but the sklearn instrumentation packages that have been published so far will continue to exist. Supporting 3.8 or not is a topic unrelated to this PR, the reason we want to deprecate this instrumentation is because the sklearn package is deprecated:

Starting 2023 December 1st, trying to install the sklearn PyPI package will raise an error.

[lzchen]

This is more like remove than deprecate, I was thinking that we may drop it when we remove support for python 3.8 maybe?

This is deprecation. We no longer will publish it, but the sklearn instrumentation packages that have been published so far will continue to exist. Supporting 3.8 or not is a topic unrelated to this PR, the reason we want to deprecate this instrumentation is because the sklearn package is deprecated:

Starting 2023 December 1st, trying to install the sklearn PyPI package will raise an error.

@ocelotl

Might want to include this in the CHANGELOG.md that this is deprecated at least.

@xrmx

We do have precedence of simply deleting packages when they are being deprecated, although, we should probably be more transparent to users. #1366

[emdneto]

Should we remove the package from the CI in the core repo?

[xrmx]

@xrmx

We do have precedence of simply deleting packages when they are being deprecated, although, we should probably be more transparent to users. #1366

You are breaking current opentelemetry-bootstrap users no? It won't install the package anymore.

BTW it's not that I care this specific package but would like to avoid surprises downstream :) boto instrumentation probably is in an even worse state.

[ocelotl]

@xrmx
We do have precedence of simply deleting packages when they are being deprecated, although, we should probably be more transparent to users. #1366

You are breaking current opentelemetry-bootstrap users no? It won't install the package anymore.

BTW it's not that I care this specific package but would like to avoid surprises downstream :) boto instrumentation probably is in an even worse state.

Trying to install sklearn already raises an error, so I don't think this is actually breaking.

[ocelotl]

@ocelotl

Might want to include this in the CHANGELOG.md that this is deprecated at least.

It is already added.

[ocelotl]

Should we remove the package from the CI in the core repo?

I'll do that ✌️