feat(urllib3)!: refactor request hook parameters#2711
feat(urllib3)!: refactor request hook parameters#2711lzchen merged 2 commits intoopen-telemetry:mainfrom
Conversation
.../opentelemetry-instrumentation-urllib3/src/opentelemetry/instrumentation/urllib3/__init__.py
Show resolved
Hide resolved
|
There are failed checks in Perhaps, it should be |
Fix for this is here See #2712 |
2aa6be1 to
cab3f75
Compare
instrumentation/opentelemetry-instrumentation-urllib3/tests/test_urllib3_integration.py
Show resolved
Hide resolved
7fe5ac2 to
2a8fde2
Compare
method and url parameters to the request hookmethod and url parameters
method and url parametersff5a3df to
3ef65fb
Compare
|
@lzchen Done and rebased, ready for review I decided to keep the
So, the hook may still want to access |
.../opentelemetry-instrumentation-urllib3/src/opentelemetry/instrumentation/urllib3/__init__.py
Show resolved
Hide resolved
|
Alright, I'm keeping the docs "as is". Adjusted the changelog and rebased. Ready for merge |
Description
Currently, in the
urllib3instrumentation, there is no way for a request hook to inspect HTTP method and URL. This change implements forwarding the new parameters to request hooks.Additionally, the documentation has been updated: both to represent the changes from this PR, and to fix the incorrect hook signatures.
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
The unit tests have been updated to verify moving the existing
bodyparameter and the newly added parameters.Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.