Adds back retry_attempts to botocore#275
Merged
codeboten merged 6 commits intoopen-telemetry:masterfrom Jan 6, 2021
Merged
Conversation
thomasdesr
requested review from
a team,
ocelotl and
toumorokoshi
and removed request for
a team
thomasdesr
force-pushed
the
thomas/botocore-retry_attempts
branch
from
138ee52 to
b11c016
Compare
toumorokoshi
suggested changes
Dec 26, 2020
Member
toumorokoshi
left a comment
toumorokoshi
left a comment
There was a problem hiding this comment.
for now, I'd leave out "aws.retry_attempts", because it's not specific to AWS.
|
|
||
| if "RetryAttempts" in metadata: | ||
| span.set_attribute( | ||
| "aws.retry_attempts", metadata["RetryAttempts"], |
Member
There was a problem hiding this comment.
Is aws.retry_attempts the right choice? The original code seems to just have retry_attempts.
That makes sense to me, as retry attempts, albeit behavior in AWS's boto, is not really in aws-specific construct.
retry attempts actually seems quite generic, it probably should be a semantic convention in the spec.
Contributor
Author
|
Thanks for taking a look! Moved back to just plain |
codeboten
suggested changes
Jan 4, 2021
Contributor
codeboten
left a comment
codeboten
left a comment
There was a problem hiding this comment.
Thanks for the PR! It looks great, if you could add an entry to the changelog for this, I can approve and merge.
Contributor
Author
|
Thanks for the reviews & project in general :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
retry_attemptsfield ininstrumentation-botocorepreviously reported how many retries it took botocore to complete an API request (e.g. if the client is rate limited).It was lost during this refactor #150 & and I can't find any comments or issues saying it was intentionally dropped (sorry if I missed this!).
So this PR adds it back :D
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.
(Lmk if you want me to add this to the changelog)