Ensure SQLAlchemy spans have kind set to CLIENT#278
Merged
codeboten merged 2 commits intoopen-telemetry:masterfrom Jan 5, 2021
Merged
Ensure SQLAlchemy spans have kind set to CLIENT#278codeboten merged 2 commits intoopen-telemetry:masterfrom
codeboten merged 2 commits intoopen-telemetry:masterfrom
Conversation
owais
requested review from
a team,
lzchen and
toumorokoshi
and removed request for
a team
owais
force-pushed
the
db-span-kind
branch
2 times, most recently
from
b8f2d46 to
25f7151
Compare
codeboten
reviewed
Jan 4, 2021
Contributor
codeboten
left a comment
codeboten
left a comment
There was a problem hiding this comment.
Change looks good, just waiting on an answer to my question before approving.
opentelemetry-python-core
Outdated
| @@ -0,0 +1 @@ | |||
| ../opentelemetry-python No newline at end of file | |||
Contributor
There was a problem hiding this comment.
Is this file expected as part of this change?
Contributor
Author
There was a problem hiding this comment.
No, this is not expected. This was supposed to be a draft PR. I probably created a regular PR by accident. Will fix in the morning.
SQLAlchemy spans were missing kind field and it was being set to internal instead of client. This commit changes sqlalchemy spans to have kind set to "client" instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
SQLAlchemy spans were missing kind field and it was being set to
internal instead of client. This commit changes sqlalchemy spans to have
kind set to "client" instead.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.