feat: add ability to optionally disable internal HTTP send and receive spans#2802
Merged
lzchen merged 28 commits intoopen-telemetry:mainfrom Sep 10, 2024
Merged
Conversation
Tested-by: Tobias Backer Dirks <omgitsaheadcrab@gmail.com>
|
|
lzchen
reviewed
Aug 16, 2024
...lemetry-instrumentation-asgi/src/opentelemetry/instrumentation/asgi/environment_variables.py
Outdated
Show resolved
Hide resolved
lzchen
reviewed
Aug 19, 2024
...tation/opentelemetry-instrumentation-asgi/src/opentelemetry/instrumentation/asgi/__init__.py
Outdated
Show resolved
Hide resolved
xrmx
reviewed
Aug 19, 2024
...tation/opentelemetry-instrumentation-asgi/src/opentelemetry/instrumentation/asgi/__init__.py
Outdated
Show resolved
Hide resolved
...tation/opentelemetry-instrumentation-asgi/src/opentelemetry/instrumentation/asgi/__init__.py
Outdated
Show resolved
Hide resolved
omgitsaheadcrab
commented
Aug 20, 2024
.../opentelemetry-instrumentation-fastapi/src/opentelemetry/instrumentation/fastapi/__init__.py
Show resolved
Hide resolved
lzchen
reviewed
Aug 20, 2024
...tation/opentelemetry-instrumentation-asgi/src/opentelemetry/instrumentation/asgi/__init__.py
Outdated
Show resolved
Hide resolved
Contributor
Author
|
|
xrmx
reviewed
Aug 23, 2024
Contributor
xrmx
left a comment
There was a problem hiding this comment.
Next time please better shut up pylint warnings on methods size and do the separation in helpers separately to ease review
instrumentation/opentelemetry-instrumentation-asgi/tests/test_asgi_middleware.py
Show resolved
Hide resolved
xrmx
reviewed
Aug 23, 2024
instrumentation/opentelemetry-instrumentation-asgi/tests/test_asgi_middleware.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
xrmx
approved these changes
Aug 26, 2024
lzchen
approved these changes
Aug 26, 2024
Contributor
|
Changes look good to us! I think you have a few tests that are failing as a result of your changes. |
Contributor
Author
|
Ugh! I ran it with assert locally and it worked, didn't check the self.assertTrue suggestion. I'm away from home on leave now so I'll see if I can fix whatever broke from another pc 🤔 |
Contributor
Author
xrmx
pushed a commit
to xrmx/opentelemetry-python-contrib
that referenced
this pull request
Jan 24, 2025
Open
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the issue where it is not possible to disable internal HTTP send and receive spans. For many members of the community these do not provide any value and only add noise to the traces. Other mechanisms of filtering them out, such as wrapping span processors or exporters are clunky.
Providing arguments that allow users to disable one or both of these would be of great benefit.
Fixes #831 and addresses user comments in the now closed PR #815
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.