fix grpc supported version#2845
Conversation
Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
xrmx
left a comment
There was a problem hiding this comment.
Given you are the first to report I think we don't have many users with older grpc then
|
@xrmx can you help add an |
There was a problem hiding this comment.
I think you need to add the changelog and also change the code in instrumentation/opentelemetry-instrumentation-grpc/package.py to match documentation and then run python scripts/generate_instrumentation_bootstrap.py to regenerate bootstrap_gen.py
$ python3 scripts/generate_instrumentation_bootstrap.py
>>> black --config github/opentelemetry-python-contrib/pyproject.toml .
reformatted github/opentelemetry-python-contrib/opentelemetry-instrumentation/src/opentelemetry/instrumentation/bootstrap_gen.py
All done! ✨ 🍰 ✨
1 file reformatted, 12 files left unchanged.
>>> isort --settings-path github/opentelemetry-python-contrib/.isort.cfg --profile black .
INFO:instrumentation_list_generator:generatedgithub/opentelemetry-python-contrib/opentelemetry-instrumentation/src/opentelemetry/instrumentation/bootstrap_gen.pyThere seems to be no changes in |
|
Yeah to the list of things to update I forgot the package |
thx, done~ |
|
@JaredTan95 Please add the changelog and we are good I guess |
emdneto
left a comment
There was a problem hiding this comment.
And also at the end run tox -e generate
Description
Our python application uses
grpcio==1.34.0(greater than version1.27as described in the documentation)The
opentelemetry-instrumentation-grpc 1.27.0plugin conflicts withgrpcio==1.34.0, resulting in the following error:This has been fixed for grpc in version
1.42.03 years ago: grpc/grpc@9699580