Remove 'component' span attribute in instrumentations#301
Merged
lzchen merged 5 commits intoopen-telemetry:mainfrom Jan 29, 2021
Merged
Remove 'component' span attribute in instrumentations#301lzchen merged 5 commits intoopen-telemetry:mainfrom
lzchen merged 5 commits intoopen-telemetry:mainfrom
Conversation
mariojonke
requested review from
a team,
lzchen and
toumorokoshi
and removed request for
a team
lzchen
approved these changes
Jan 27, 2021
codeboten
reviewed
Jan 27, 2021
Contributor
codeboten
left a comment
codeboten
left a comment
There was a problem hiding this comment.
PR looks great, just one question regarding whether database_type should be removed as well.
| "jdbc", "odbc", "postgreSQL". | ||
| database_system: An identifier for the database management system (DBMS) | ||
| product being used. | ||
| database_type: The Database type. For any SQL database, "sql". |
Contributor
There was a problem hiding this comment.
should database_type be removed? i couldn't find it in the semantic conventions for databases
Contributor
Author
There was a problem hiding this comment.
Yes looks like there are no semantic convetions for it. It also doesn't seem to be used anywhere in the code so i'll remove it.
owais
approved these changes
Jan 27, 2021
toumorokoshi
approved these changes
Jan 29, 2021
codeboten
approved these changes
Jan 29, 2021
Contributor
codeboten
left a comment
codeboten
left a comment
There was a problem hiding this comment.
Thanks for addressing my comments!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #300
Type of change
Does This PR Require a Core Repo Change?
Checklist: