bug_fix(1477): type handling in _add_sql_comment#3113
bug_fix(1477): type handling in _add_sql_comment#3113xrmx merged 27 commits intoopen-telemetry:mainfrom
Conversation
|
|
xrmx
left a comment
There was a problem hiding this comment.
Thanks for the PR, could you please add a test so we are sure that the code is fixing the reported issue?
opentelemetry-instrumentation/src/opentelemetry/instrumentation/sqlcommenter_utils.py
Outdated
Show resolved
Hide resolved
5cb5d9d to
577f808
Compare
5e98fce to
cc7332d
Compare
|
@tammy-baylis-swi Please let me what all changes are required. |
tammy-baylis-swi
left a comment
There was a problem hiding this comment.
Thanks again! Lgtm
|
@Kludex Please can you review? |
|
@xrmx @tammy-baylis-swi can we merge this? |
|
Hi @Kludex can we merge this? |
...tion/opentelemetry-instrumentation-dbapi/src/opentelemetry/instrumentation/dbapi/__init__.py
Show resolved
Hide resolved
|
Please stop pinging me. I do not have bandwidth to review this again. I've shared my concerns already. |
I have replied to your comment. |
|
@xrmx Please have a look, if this is not accepted then we can close this PR. |
|
@aryabharat Please stop pinging people, this will be merged eventually. |
Description
This PR fixes an issue with SQL comment generation, the current implementation fails when processing non-string SQL queries, particularly those from psycopg2's SQL utilities.
Modified _add_sql_comment() function to handles different SQL query types by converting incoming sql queries to strings
Preserves the original query if comment generation fails
Fixes #1477
Type of change
Please delete options that are not relevant.