Remove metrics from main branch #312
Merged
lzchen merged 21 commits intoopen-telemetry:mainfrom Feb 6, 2021
Merged
Conversation
lzchen
requested review from
a team,
hectorhdzg and
ocelotl
and removed request for
a team
lzchen
changed the title
ocelotl
approved these changes
Feb 5, 2021
codeboten
approved these changes
Feb 5, 2021
Contributor
codeboten
left a comment
codeboten
left a comment
There was a problem hiding this comment.
Just one question, otherwise it looks good.
| # pylint:disable=W0212 | ||
| request._otel_labels["http.status_code"] = str( | ||
| response.status_code | ||
| ) |
Contributor
There was a problem hiding this comment.
it looks like this was removed accidentally, i dont see this being metric related
Contributor
Author
There was a problem hiding this comment.
It was not removed accidently. request.otel_labels was added as a way to pass the labels needed to create duration metrics.
Contributor
|
is there an alternative available for this package? |
Contributor
Author
|
@mihirg |
flands
pushed a commit
to open-telemetry/opentelemetry.io
that referenced
this pull request
Jun 26, 2021
System metrics were moved to a separate branch in open-telemetry/opentelemetry-python-contrib#312
|
The docs seem broken in the process? |
Contributor
Author
|
@luckydonald |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Core pr: open-telemetry/opentelemetry-python#1568
As part of the discussion here