Add mysql-connector instrumentor support for sqlcommenting#3163
Merged
lzchen merged 12 commits intoopen-telemetry:mainfrom Jan 30, 2025
Merged
Add mysql-connector instrumentor support for sqlcommenting#3163lzchen merged 12 commits intoopen-telemetry:mainfrom
lzchen merged 12 commits intoopen-telemetry:mainfrom
Conversation
4 tasks
Contributor
Author
Contributor
|
Does this need the |
lzchen
approved these changes
Jan 14, 2025
Contributor
Author
Good call! Added in d2c7076 |
Contributor
Author
|
Any other changes needed? 🙂 |
xrmx
approved these changes
Jan 28, 2025
lzchen
approved these changes
Jan 30, 2025
aryabharat
pushed a commit
to aryabharat/opentelemetry-python-contrib
that referenced
this pull request
Feb 2, 2025
aryabharat
added a commit
to aryabharat/opentelemetry-python-contrib
that referenced
this pull request
Feb 4, 2025
aryabharat
added a commit
to aryabharat/opentelemetry-python-contrib
that referenced
this pull request
Feb 4, 2025
…pen-telemetry#3163)" This reverts commit d83a5c4.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates mysql-connector instrumentor to support sqlcommenting. Includes support for
enable_attribute_commenterlike the other drivers.Fixes #2902
Replaces #3023
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
tox -e py312-test-instrumentation-mysql-0instrument(); checked MySQL server general logs after queryinstrument_connection; checked MySQL server general logs after queryDoes This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.